cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31012] - CachingPipeline validity and new IncludeTransformer
Date Mon, 06 Sep 2004 22:11:34 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31012>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31012

CachingPipeline validity and new IncludeTransformer

oliver.powell@tvnz.co.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cmoss@tvnz.co.nz
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From oliver.powell@tvnz.co.nz  2004-09-06 22:11 -------
The committed patch doesn't quite work for me - and it's due to the following 
condition in the getValidityForEventPipeline method:

if (this.cachedResponse != null && this.completeResponseIsCached)

My understanding is that this.completeResponseIsCached will never be true if 
your current pipeline context is a nested or internal one. This is because in 
the generateCachingKey method, this.cacheCompleteResponse 
(this.completeResponseIsCached is a copy of this variable) is set to true only 
if super.serializer == this.lastConsumer (line # 338).

This doesn't meet our needs as we have several nested CIncluded pipelines that 
should be able to return the validities from the CachedResponse when 
getValidityForEventPipeline() is called.

It all works fine if we remove the '&& this.completeResponseIsCached' from the 
if condition. Can we do this? Or would it cause a problem elsewhere?

Mime
View raw message