Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <41215B6F.20701@reverycodes.com>
Date: Mon, 16 Aug 2004 21:12:15 -0400
From: Vadim Gritsenko <vadim@reverycodes.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.7) Gecko/20040616
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: Bring the new I18NMatcher in line with LocaleAction [Bug 30046]
References: <20040809143427.23772.qmail@nagoya.betaversion.org>
 <4118F734.10304@upaya.co.uk> <411979E3.8000302@reverycodes.com>
 <4119E88B.90006@upaya.co.uk> <411BB4BA.4030306@reverycodes.com>
 <411BD949.8040604@upaya.co.uk> <411D57E9.1090300@reverycodes.com>
 <411FC619.8070002@upaya.co.uk>
In-Reply-To: <411FC619.8070002@upaya.co.uk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Upayavira wrote:

> Vadim Gritsenko wrote:
> 
>> Ok, I (majorly) reworked both LocaleAction and I18nMatcher.
>>
>> Also, I removed "language-attribute", "country-attribute", 
>> "variant-attribute" configuration elements from LocaleAction - IMHO 
>> they are clear FS - what's the point in customizing sitemap variable 
>> names. Language sitemap variable renamed to "language", same as in 
>> I18nMatcher.
> 
> 
> Fair enough. Although it is a feature removal.

Is it (necessarily) bad? Mentioning in the "Update" doc should be enough.


>> Please take a look, check that everything is ok :-)
>>
>> I was thinking: may be I18nMatcher should be renamed to LocaleMatcher?
> 
> 
> I had thought of that myself. I'm okay with that too.

I'll go then with renaming it and merging it into the 2.1 branch.

Vadim