cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Upayavira>
Subject Re: Bring the new I18NMatcher in line with LocaleAction [Bug 30046]
Date Sun, 15 Aug 2004 20:22:49 GMT
Vadim Gritsenko wrote:

> Upayavira wrote:
>> Fine by me too!
> Ok, I (majorly) reworked both LocaleAction and I18nMatcher. I also 
> noticed that original I18nMatcher was not properly handling locales 
> with countries and variants (AFAIU, constructor new Locale(locale, "") 
> as first argument takes language and not locale string).

Great. I'm no I18n expert, so these are details I wasn't able to take 
care of.

> Also, I removed "language-attribute", "country-attribute", 
> "variant-attribute" configuration elements from LocaleAction - IMHO 
> they are clear FS - what's the point in customizing sitemap variable 
> names. Language sitemap variable renamed to "language", same as in 
> I18nMatcher.

Fair enough. Although it is a feature removal.

> Please take a look, check that everything is ok :-)
> I was thinking: may be I18nMatcher should be renamed to LocaleMatcher?

I had thought of that myself. I'm okay with that too.

Regards, Upayavira

View raw message