Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 76701 invoked from network); 12 Jul 2004 06:50:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 12 Jul 2004 06:50:42 -0000 Received: (qmail 43561 invoked by uid 500); 12 Jul 2004 06:50:38 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 43518 invoked by uid 500); 12 Jul 2004 06:50:37 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 43505 invoked by uid 99); 12 Jul 2004 06:50:37 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [212.8.217.2] (HELO mail.s-und-n.de) (212.8.217.2) by apache.org (qpsmtpd/0.27.1) with ESMTP; Sun, 11 Jul 2004 23:50:36 -0700 Received: from notes.sundn.de (ntsrv5.sundn.de [10.10.2.10]) by mail.s-und-n.de (postfix) with ESMTP id B812519F612 for ; Mon, 12 Jul 2004 08:50:34 +0200 (CEST) Received: from hw0386 ([10.10.2.43]) by notes.sundn.de (Lotus Domino Release 6.5) with ESMTP id 2004071208401230-39944 ; Mon, 12 Jul 2004 08:40:12 +0200 From: "Carsten Ziegeler" To: "Cocoon-Dev" Subject: Questions about the CocoonTask class Date: Mon, 12 Jul 2004 08:50:51 +0200 Organization: S&N AG MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook, Build 11.0.5510 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 Thread-Index: AcRn3JIGMws99EKMR9ChXWU8aM6ruw== X-MIMETrack: Itemize by SMTP Server on PBSN1/Systeme und Netzwerke(Release 6.5|September 26, 2003) at 12.07.2004 08:40:12, Serialize by Router on PBSN1/Systeme und Netzwerke(Release 6.5|September 26, 2003) at 12.07.2004 08:40:13, Serialize complete at 12.07.2004 08:40:13 Message-ID: Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii" X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N The CocoonTask class in o.a.c has a javadoc error for the execute() method: /** * Do the execution and return a return code. * * @return the return code from the execute java class if it was * executed in a separate VM (fork = "yes"). * * @throws BuildException if required parameters are missing */ public void execute() throws BuildException { // FIXME - This is never read int err= -1; This method doesn't return anything, so the javadoc is wrong. It seems that the original author wanted to return the int "err", but the signature of execute() (from Ant's Task class) doesn't allow this. I guess that a BuildException should be thrown? Carsten Carsten Ziegeler Open Source Group, S&N AG http://www.s-und-n.de http://www.osoco.net/weblogs/rael/