cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 29881] - [PATCH] Problems using datatype type="date" variant="time"
Date Sun, 04 Jul 2004 14:47:44 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29881>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29881

[PATCH] Problems using datatype type="date" variant="time"

joerg.heinicke@gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From joerg.heinicke@gmx.de  2004-07-04 14:47 -------
I committed it the following way:

1. To point out the variants I used the scheme datatype.{datatype}.{variant} for
the i18n keys, i.e. datatype.date.datetime for example.

2. I avoided to convert the strings to ints forth and back, maybe it makes sense
to preserve additionally the int to avoid the String.equals() tests in
getDateFormat(Locale locale).

3. The stylesheet tests for variant='date' explicitely.

Thanks very much for your effort. Please cross-test and close the bug afterwards.

Joerg

PS: You had a strange patch format. What is the meaning of the exclamation
marks? I also wonder your patch has worked as you added the variant attribute
after you fired the element event through the pipeline.

Mime
View raw message