Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 71218 invoked from network); 2 Jun 2004 12:08:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 2 Jun 2004 12:08:14 -0000 Received: (qmail 45250 invoked by uid 500); 2 Jun 2004 12:08:10 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 45053 invoked by uid 500); 2 Jun 2004 12:08:09 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 45038 invoked by uid 99); 2 Jun 2004 12:08:08 -0000 Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.27.1) with SMTP; Wed, 02 Jun 2004 05:08:08 -0700 Received: (qmail 24659 invoked by uid 50); 2 Jun 2004 12:09:03 -0000 Date: 2 Jun 2004 12:09:03 -0000 Message-ID: <20040602120903.24658.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: dev@cocoon.apache.org Cc: Subject: DO NOT REPLY [Bug 29061] - XMLDBSource: default character encoding X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29061 XMLDBSource: default character encoding ------- Additional Comments From uv@upaya.co.uk 2004-06-02 12:09 ------- Thanks for the patch (you got your two filenames the wrong way around it seems, but otherwise the patch creation process worked fine). What you have done is added a new close() method that supplies an encoding. The close() method is a standard part of the OutputStream interface, so we cannot assume that someone will call a different version of close. What we need is a way to configure the XMLDBSource with an output encoding. Maybe, adding an output-encoding attribute to the node within the XMLDB configuration in cocoon.xconf. This woul need to be interpreted within the XMLDBSourceFactory, and probably stored as a database property, so that the XMLDBSource can access it when it does the close() operation. Upayavira