cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@s-und-n.de>
Subject RE: [BUG] XMLUtils method has chaneged
Date Fri, 18 Jun 2004 13:13:11 GMT
 

> -----Original Message-----
> From: Vadim Gritsenko [mailto:vadim@reverycodes.com] 
> Sent: Friday, June 18, 2004 2:56 PM
> To: dev@cocoon.apache.org
> Subject: Re: [BUG] XMLUtils method has chaneged
> 
> Carsten Ziegeler wrote:
> 
> >>-----Original Message-----
> >>From: Klaus Bertram [mailto:k.bertram@kbsm.de]
> >>Sent: Thursday, June 17, 2004 12:35 PM
> >>To: cocoon-dev
> >>Subject: [BUG] XMLUtils method has chaneged
> >>
> >>Hi all,
> >>
> >>the samples binding.js with XML call the "old" function at LN 96
> >>org.apache.cocoon.xml.XMLUtils.serializeNodeToXML(node)
> >>but this not at the class
> >>
> >>I think it must be:
> >>Packages.org.apache.cocoon.xml.XMLUtils.serializeNode(node,
> >>   
> >>Packages.org.apache.cocoon.xml.XMLUtils.createPropertiesForX
> ML(true));
> >>
> >>but not sure ;)
> >>    
> >>
> >Hmm, not sure, but I think the argument should be "false".
> >
> >I don't have CVS access right now, can someone please correct this?
> >  
> >
> 
> Ok, corrected.
> 
> But I see at least one issue with XMLUtils usage like:
> 
>     Properties props = XMLUtils.createPropertiesForXML(false);
>     props.put(OutputKeys.ENCODING, "ISO-8859-1");
>     final String content = XMLUtils.serializeNode(frag, props);
> 
> 
> At least Xalan's TransformerIdentityImpl does not uses 
> OutputKeys.ENCODING, as far as I can see. Also, why 
> ISO-8859-1 is hardcoded. May be this encoding stuff should be 
> removed from properties at all?
> 
Where do you see this? We have removed the encoding stuff from XMLUtils
some time ago, so it shouldn't be there :)

Carsten


Mime
View raw message