cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: Bug in XMLFileModule
Date Thu, 24 Jun 2004 01:13:24 GMT
Roth, Scott wrote:

>The XMLFileModule doesn't first call isValid().
>See line 170:
>"if (srcVal != null && this.srcVal.isValid(valid) != 1) {"
>It goes right to testing isValid(SourceValidity).
>
>Anyway, because the SourceValidity implementations are expecting the 2
>methods to both be called, it is possible to get unexpected behavior when
>only the second call is made.  In my case (using ExpiresValidity), the file
>was being reloaded on every request because this SourceValidity
>implementation always returns INVALID for isValid(SourceValidity).  (It
>never expects that call to be made because isValid() never returns UNKNOWN.)
>  
>

I've committed a fix; please verify that it actually fixes the issue.

Vadim


Mime
View raw message