cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leo leonid <...@leonid.de>
Subject Re: cvs commit: cocoon-2.1/src/java/org/apache/cocoon/components/flow/javascript/fom FOM_JavaScriptInterpreter.java
Date Mon, 17 May 2004 17:13:46 GMT

On 17.05.2004, at 18:12, Vadim Gritsenko wrote:

> Do those bugs disappear after patch is reverted?
>

Yep. I can't actually test the petstore and linotype samples, cause I  
don't have CVS here, but I fixed some of my projects that have been  
suffering from the same symptoms by simply reverting your patch. Fixing  
it in any way before the release would be nice :)

/leo

> Instead of request.isRequestedSessionIdValid() I can put a try/catch  
> block; but behavior in this case will be different in Tomcat and  
> Jetty.
>
> Vadim
>
>
> leo leonid wrote:
>
>>
>> Could this commit be the cause of
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=29008
>>
>> (and possibly of
>> http://issues.apache.org/bugzilla/show_bug.cgi?id=29009 , too?)
>>
>> /leo
>>
>>
>> On 05.05.2004, at 19:08, vgritsenko@apache.org wrote:
>>
>>> vgritsenko    2004/05/05 10:08:05
>>>
>>>   Modified:      
>>> src/java/org/apache/cocoon/components/flow/javascript/fom
>>>                         FOM_JavaScriptInterpreter.java
>>>   Log:
>>>   Check for valid session. Fixes exception running in Tomcat:
>>>   ERROR   (2004-05-05) 12:06.15:469   [sitemap.handled-errors]   
>>> (/cc/samples/blocks/slide/logout.do)  
>>> http8080-Processor5/PipelineNode:  Cannot create a session after the  
>>> response has been committed
>>>   java.lang.IllegalStateException: Cannot create a session after the  
>>>  response has been committed
>>>       at   
>>> org.apache.coyote.tomcat5.CoyoteRequest.doGetSession(CoyoteRequest.ja 
>>> va :2281)
>>>
>>>   Revision  Changes    Path
>>>   1.29      +13 -9       
>>> cocoon-2.1/src/java/org/apache/cocoon/components/flow/javascript/ 
>>> fom/ FOM_JavaScriptInterpreter.java
>>>
>>>   Index: FOM_JavaScriptInterpreter.java
>>>   ===================================================================
>>>   RCS file:   
>>> /home/cvs/cocoon-2.1/src/java/org/apache/cocoon/components/flow/  
>>> javascript/fom/FOM_JavaScriptInterpreter.java,v
>>>   retrieving revision 1.28
>>>   retrieving revision 1.29
>>>   diff -u -r1.28 -r1.29
>>>   --- FOM_JavaScriptInterpreter.java    5 May 2004 16:00:11 -0000     
>>> 1.28
>>>   +++ FOM_JavaScriptInterpreter.java    5 May 2004 17:08:05 -0000     
>>> 1.29
>>>   @@ -376,16 +376,20 @@
>>>         */
>>>        private Scriptable setSessionScope(Scriptable scope) throws   
>>> Exception {
>>>            Request request =   
>>> ContextHelper.getRequest(this.avalonContext);
>>>   -        Session session = request.getSession(true);
>>>
>>>   -        HashMap userScopes =   
>>> (HashMap)session.getAttribute(USER_GLOBAL_SCOPE);
>>>   -        if (userScopes == null) {
>>>   -            userScopes = new HashMap();
>>>   -            session.setAttribute(USER_GLOBAL_SCOPE, userScopes);
>>>   -        }
>>>   +        // Check that session is available (avoids   
>>> IllegalStateException)
>>>   +        if (request.isRequestedSessionIdValid()) {
>>>   +            Session session = request.getSession(true);
>>>   +
>>>   +            HashMap userScopes =   
>>> (HashMap)session.getAttribute(USER_GLOBAL_SCOPE);
>>>   +            if (userScopes == null) {
>>>   +                userScopes = new HashMap();
>>>   +                session.setAttribute(USER_GLOBAL_SCOPE,  
>>> userScopes);
>>>   +            }
>>>
>>>   -        // Attach the scope to the current context
>>>   -        userScopes.put(getSitemapPath(), scope);
>>>   +            // Attach the scope to the current context
>>>   +            userScopes.put(getSitemapPath(), scope);
>>>   +        }
>>>            return scope;
>>>        }
>>>
>>>
>>>
>>>
>>>
>>
>>
>
>


Mime
View raw message