cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <va...@reverycodes.com>
Subject Re: CForms validator function Re: cvs commit: cocoon-2.1/src/blocks/forms/samples/forms sitemap.xmap customvalidationdemo_form.xml customvalidationdemo_template.xml
Date Thu, 06 May 2004 21:19:08 GMT
Sylvain Wallez wrote:

> Bruno Dumon wrote:
>
>> On Thu, 2004-05-06 at 16:23, vgritsenko@apache.org wrote:
>>  
>>
>>> vgritsenko    2004/05/06 07:23:04
>>>
>>>  Modified:    .        status.xml
>>>               src/blocks/forms/samples sitemap.xmap welcome.xml
>>>               
>>> src/blocks/forms/java/org/apache/cocoon/forms/flow/javascript
>>>                        Form.js
>>>               
>>> src/blocks/forms/java/org/apache/cocoon/forms/flow/javascript/v2
>>>                        Form.js
>>>               
>>> src/blocks/forms/java/org/apache/cocoon/forms/flow/javascript/v3
>>>                        Form.js
>>>               src/blocks/forms/samples/forms sitemap.xmap
>>>  Removed:     src/blocks/forms/samples/flow customvalidationdemo.js
>>>               src/blocks/forms/samples/forms 
>>> customvalidationdemo_form.xml
>>>                        customvalidationdemo_template.xml
>>>  Log:
>>>  Remove flow level custom validators
>>>  http://marc.theaimsgroup.com/?t=108091920700001&r=1&w=2
>>>  
>>>   
>>
>>
>> (I highly appreciate the cleanup work, but...)
>>
>> Allthough the flow-level validator function was a hack, won't it be too
>> annoying for users who are relying on it to throw it out completely?
>> This will make the woody -> cforms move a bit harder...
>>  
>>
>
> Cleaning up means so backwards incompatibilities, and I'm +1000 to 
> remove this hack. What we can do however, is check if a "validator" 
> property exists in a form object and fail hard with an exception if it 
> exists. That way, users will be informed that this "feature" has been 
> removed.


Done


>> Also, couldn't the example be updated to how it should be done now?
>

Added to the "Various" example. On a plus side: now same validator works 
both with flow and without it.

Vadim



Mime
View raw message