Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 4953 invoked from network); 17 Apr 2004 15:00:47 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 17 Apr 2004 15:00:47 -0000 Received: (qmail 10657 invoked by uid 500); 17 Apr 2004 15:00:38 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 10615 invoked by uid 500); 17 Apr 2004 15:00:38 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 10596 invoked from network); 17 Apr 2004 15:00:37 -0000 Received: from unknown (HELO grid4.hypergrid.it) (80.22.58.138) by daedalus.apache.org with SMTP; 17 Apr 2004 15:00:37 -0000 Received: (qmail 17371 invoked by uid 1005); 17 Apr 2004 15:00:38 -0000 Received: from ugo@apache.org by mail with HyperGrid Anti-Virus System Processed in 5.778229 secs; 17 Apr 2004 15:00:38 -0000 Received: from unknown (HELO ?80.117.39.141?) (ugo.cei@ymail.it@80.117.39.141) by 0 with RC4-SHA encrypted SMTP; 17 Apr 2004 15:00:32 -0000 Mime-Version: 1.0 (Apple Message framework v613) In-Reply-To: <1FEF7C54-907A-11D8-B9D8-000A95AF004E@apache.org> References: <1FEF7C54-907A-11D8-B9D8-000A95AF004E@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Ugo Cei Subject: Re: [POLL] don't edit files just for style changes? Date: Sat, 17 Apr 2004 17:00:33 +0200 To: dev@cocoon.apache.org X-Mailer: Apple Mail (2.613) X-Spam-Checker-Version: SpamAssassin 3.0.0-r9592-hypergrid (2004-03-18) on mail.hypergrid.it X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Il giorno 17/apr/04, alle 16:18, Bertrand Delacretaz ha scritto: > I have three suggestions: > > 1) As a general rule, we should refrain from making such changes to > our code, unless there is a good reason (code change for example) to > edit the file in question. > > 2) When editing a file for a good reason, we should look for such > "style" problems and fix them at the same time, or as a separate > commit, but before testing our changes. > > 3) We should not change the indentation / code writing style (brackets > etc.) of a file when making a minor change to it. > > The idea is to keep the flow of CVS diff messages as low as possible, > to save our neuronal bandwidth for more important things than the > placement of brackets or the order of imports. > > WDYT? > + 1 Ugo