Return-Path: 
 <dev-return-59275-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 34626 invoked from network); 12 Apr 2004 16:22:09 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 12 Apr 2004 16:22:09 -0000
Received: (qmail 65383 invoked by uid 500); 12 Apr 2004 16:21:57 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 65339 invoked by uid 500); 12 Apr 2004 16:21:56 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 65314 invoked from network); 12 Apr 2004 16:21:56 -0000
Received: from unknown (HELO smtp1.xs4all.be) (195.144.64.135)
  by daedalus.apache.org with SMTP; 12 Apr 2004 16:21:56 -0000
Received: from outerthought.org (195-144-088-038.dyn.adsl.xs4all.be
 [195.144.88.38])
	(authenticated bits=0)
	by smtp1.xs4all.be (8.12.10/8.12.10) with ESMTP id i3CGLwPQ029158
	for <dev@cocoon.apache.org>; Mon, 12 Apr 2004 18:21:58 +0200
Message-ID: <407AC226.7090406@outerthought.org>
Date: Mon, 12 Apr 2004 18:21:58 +0200
From: Marc Portier <mpo@outerthought.org>
Organization: Outerthought
User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: cvs commit:
 cocoon-2.1/src/blocks/forms/java/org/apache/cocoon/forms/transformation
 EffectPipe.java
References: <20040409163600.19996.qmail@minotaur.apache.org>
 <4076D1FB.5030801@outerthought.org> <20040412152255.GE12207@keow.org>
In-Reply-To: <20040412152255.GE12207@keow.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N



Tim Larson wrote:

> On Fri, Apr 09, 2004 at 06:40:27PM +0200, Marc Portier wrote:
> 
>>mpo@apache.org wrote:
>>
>>>mpo         2004/04/09 09:36:00
>>> Modified:    src/blocks/forms/java/org/apache/cocoon/forms/transformation
>>>                       EffectPipe.java
> 
> <snip/>
> 
>>IMHO it could not be the case: AFAIU the whole purpose of the efectpipe 
>>is to build a stack of these elements
>>that lives across SAX-EVENTS, this would mean that the current impl only 
>>works with a SAX parser impl that
>>allocates a new Attributes instance for each sax event (lucky us?)
>>
>>In that light I'm doubthing if the added complexity of the late 
>>attribute-cloning offers us that much.
>>(doesn't it need to happen anyway?)
> 
> 
> It saves creating some objects, but when looking at it again I agree
> that we should just go ahead and always clone the attributes.
> 

ok, I'll make the change then

> 
>>IMHO we should consider making the attrs final and thus cloning the lot 
>>at Element-constructot-time.
> 
> 
> IIUC, that would mean we could not add attributes via the handlers,
> or do you have a different solution for this?
> 

nope, you can still add attributes, only the reference to the actual 
AttributesImpl can never change during the life of the Element.

regards,
-marc=
-- 
Marc Portier                            http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at                http://blogs.cocoondev.org/mpo/
mpo@outerthought.org                              mpo@apache.org