Return-Path: 
 <dev-return-58986-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 21485 invoked from network); 5 Apr 2004 18:37:32 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 5 Apr 2004 18:37:32 -0000
Received: (qmail 94068 invoked by uid 500); 5 Apr 2004 18:37:19 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 93993 invoked by uid 500); 5 Apr 2004 18:37:19 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 93971 invoked from network); 5 Apr 2004 18:37:18 -0000
Received: from unknown (HELO mail.s-und-n.de) (212.8.217.2)
  by daedalus.apache.org with SMTP; 5 Apr 2004 18:37:18 -0000
Received: from notes.sundn.de (ntsrv5.sundn.de [10.10.2.10])
	by mail.s-und-n.de (postfix) with ESMTP id 15CBF19F5C3
	for <dev@cocoon.apache.org>; Mon,  5 Apr 2004 20:37:23 +0200 (CEST)
Received: from s-und-n.de ([10.10.20.145])
          by notes.sundn.de (Lotus Domino Release 6.5)
          with ESMTP id 2004040520305189-31403 ;
          Mon, 5 Apr 2004 20:30:51 +0200
Message-ID: <4071A7AF.7040007@s-und-n.de>
Date: Mon, 05 Apr 2004 20:38:39 +0200
From: Guido Casper <gcasper@s-und-n.de>
User-Agent: Mozilla Thunderbird 0.5 (Windows/20040207)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: [PROP] Repository interface
References: <1081163986.2215.41.camel@gideon.rkunet.org>
	 <4071454B.6090601@s-und-n.de> <1081166006.2215.45.camel@gideon.rkunet.org>
In-Reply-To: <1081166006.2215.45.camel@gideon.rkunet.org>
X-MIMETrack: Itemize by SMTP Server on PBSN1/Systeme und Netzwerke(Release
 6.5|September
 26, 2003) at 05.04.2004 20:30:52,
	Serialize by Router on PBSN1/Systeme und Netzwerke(Release 6.5|September 26,
 2003) at
 05.04.2004 20:30:52,
	Serialize complete at 05.04.2004 20:30:52
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii; format=flowed
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Rolf Kulemann wrote:
> On Mon, 2004-04-05 at 13:38, Guido Casper wrote:
> 
>>Rolf Kulemann wrote:
>>
>>>[Related to http://issues.apache.org/bugzilla/show_bug.cgi?id=28189]
>>>
>>><quote src="Guido Capser">
>>>As for WebDAVRepsoitoryVersioningHelper.setVersioned(): I don't think it
>>>is a good idea to throw an 
>>>UnsupportedOperationException only under certain conditions.
>>></quote>
>>>
>>>Agreed.
>>>
>>>Maybe it makes sense to split setVersioned(String, boolean) into two
>>>methods
>>>
>>>1.) setVersioned(String)
>>>2.) unsetVersioned(String)
>>>
>>>in order to be more flexible in the implementation decisions?
>>
>>Why should that be more flexible?
> 
> 
> Because I can decide if I implement both or only one method. The reason
> for the split is, I can use the NotSupportedException more accurate.

Well, throwing UnsupportedOperationException is not my final goal for 
either :-)

I guess having too many of those might indicate an unappropriate interface.

> 
> 
>>TBH I'm not so sure wether these should be part of the Repository 
>>interface at all as it looks like being geared towards WebDAV only (but 
>>I don't know right now).
> 
> 
> Ok, I didn't mean the Repsoitory interface, was a litlle bit confusing
> maybe, but the RepositoryVersioningHelper. And if a repository does not
> support versioning it has no helper at all.

Yes, but I was talking about the RepositoryVersioningHelper as well (a 
single repository having both versioned and non-versioned resources) 
which is exactly the point of my comment above.

I think it might be a wise move to first gather experiences with other 
implementations (instead of adding more operations coming directly from 
a WebDAV context).

Guido

-- 
Guido Casper
-------------------------------------------------
S&N AG, Competence Center Open Source
                     Tel.: +49-5251-1581-87
Klingenderstr. 5    mailto:gcasper@s-und-n.de
D-33100 Paderborn   http://www.s-und-n.de
-------------------------------------------------