cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bertrand Delacretaz <bdelacre...@codeconsult.ch>
Subject Re: [POLL] don't edit files just for style changes?
Date Mon, 19 Apr 2004 06:59:08 GMT
Le 17 avr. 04, à 17:42, Antonio Gallardo a écrit :

> Joerg Heinicke dijo:
>> IMO it's only important to separate code changes clearly from style
>> changes. For an example see
>> http://thread.gmane.org/gmane.text.xml.cocoon.cvs/11901. A replacement
>> of hand-written code with commons lang code got completely lost in a
>> huge list of style changes. It was really only luck that I saw the
>> faulty change at one place when flying over the diff.
>
> I really don't understand things now. First was told me:
>
> "Please don't commit in small chunks".
>
> Now looks like it was ok. I will committ step by step if any....

I agree with Joerg about the "separation of concerns" in commits: when 
possible, it is a good idea to commit different types of modifications 
separately. It helps find out what is what.

-Bertrand


Mime
View raw message