cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Heinicke <>
Subject Re: woody2.js: custom validation issue in cocoon-2.1.2 to 2.1.4
Date Wed, 24 Mar 2004 02:16:12 GMT
On 19.03.2004 06:43, Alex Kovacs wrote:

> Tested and it behaves the same way, i.e. does not show any custom
> validation errors until all other fields are validated correctly.
> However, this is not the change that I was hoping for ;-). 
> I think the test "if (finished)" is the problem. It only allows for
> custom validation just after the form is finished. The finished variable
> comes from some lines above in woody2.js:
> 	finished = this.form.process(formContext);
> So it seems the form is validated (i.e. finished) only if the built-in
> validation is completed. And my understanding is that the form is not
> finished until there are no errors, regardless if they are coming from
> the custom validation or not. Therefore, I still think the fix above
> does not solve my issues. I my code above I've actually removed the "if
> (finished ...)" statement to make the fix working ok.
> What do you think?

Ah, sorry for that. I hadn't the finished in mind and did not thought 
that you removed this first completely from your snippet. I will have a 
look on it.


View raw message