cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Heinicke <joerg.heini...@gmx.de>
Subject Re: DO NOT REPLY [Bug 27678] New: - AbstractXMLProducer.setConsumer implementation is incorrect
Date Mon, 15 Mar 2004 20:21:01 GMT
On 15.03.2004 19:37, bugzilla@apache.org wrote:

> http://issues.apache.org/bugzilla/show_bug.cgi?id=27678
> 
> AbstractXMLProducer.setConsumer implementation is incorrect
> 
> The implementation of org.apache.cocoon.xml.AbstractXMLProducer.setConsumer does
> not match its Javadoc.  Patch is below.  
> 
> Current workaround is to include implementation specified in Javadoc in subclass.
> 
> -        this.contentHandler = consumer;
> -        this.lexicalHandler = consumer;
> +        setContentHandler(consumer);
> +        setLexicalHandler(consumer);

This can make indeed a difference when subclassing AbstractXMLProducer, 
but the question is if it's useful usable. Shall we apply it? I guess we 
can break someone's code who implemented the both functions incorrectly, 
but never called them himself, but I don't fear this.

Joerg

Mime
View raw message