cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Heinicke <joerg.heini...@gmx.de>
Subject Re: cvs commit: cocoon-2.1/src/blocks/cron/java/org/apache/cocoon/environment/background BackgroundEnvironment.java
Date Thu, 11 Mar 2004 23:02:04 GMT
On 11.03.2004 22:57, Sylvain Wallez wrote:

>> quoting Eclipse: "The private field QuartzJobScheduler.jobEnvironment 
>> is never read locally."
>>
>> Is it needed?
> 
> Well, if Eclipse says no, I guess it's right ;-)
> 
> Seriously, this refactoring went through several iterations and the 
> location of the environment move several times: it was initially a 
> singleton, but I later changed this when I realized that background 
> request processing can use request attributes, and that therefore a 
> singleton wasn't suitable.

Thanks. I only asked, because the last time I removed such unused code I 
broke some hidden magic code, because there happened something not obvious.

Joerg

Mime
View raw message