cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 27785] - [PATCH] Form redisplays with validation errors after submit from <wd:action>
Date Thu, 25 Mar 2004 03:02:58 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=27785>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27785

[PATCH] Form redisplays with validation errors after submit from <wd:action>





------- Additional Comments From joerg.heinicke@gmx.de  2004-03-25 03:02 -------
> It was added so that the value of a field could be validated before being used
> to select a case for a "union" widget.

Unfortunately I have not worked with those new/class/struct/union widgets, so I
do not really understand what it is for.

> We should change it to only validate the
> field widgets that are actually put to this use (selecting a case for a
> "union" widget)

But this is not determinable at the moment, is it?

> Whether we should hide the messages in that case like the proposed patch
> does, I do not know.

If the validation is needed or at least good for further processing, what should
be the sense of not showing an error?

> When "union" get replaced by the redesigned "choice"
> widget we will still have this issue, but it will get triggered by the "expr"
> attributes' expressions referencing the values in various widgets.

Ok, just a proposal, don't know if you can live with it: If there is a
refactoring still to be done and the validation is only "good" not necessary,
what about removing this stuff (at least additional getValue()) for now. This
will make all other fields behave normally again while it seems not to break the
new widgets (which are furthermore not that common in use I guess).

WDYT?

Joerg

Mime
View raw message