cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 25934] - [PATCH] LuceneIndexContentHandler.java produces CLOBs
Date Tue, 23 Mar 2004 17:51:54 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=25934>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=25934

[PATCH] LuceneIndexContentHandler.java produces CLOBs





------- Additional Comments From pmhahn@titan.lahn.de  2004-03-23 17:51 -------
Applies to both patches:

@@ -130,6 +129,8 @@
...
+            text.append(' ');
This doen't look like it's necesarry: "text" contains only the concatenated
children text-nodes of the current node. It's only used when the current node is
closed, where the text is passed for indexing or storing.

+            bodyText.append(' ');
I think this is the relevant line and it looks correct.

After thinking more and more about this problem, I'm no longer sure that adding
spaces is always the right solution to the problem. You already posted two
examples where adding spaces is wrong, while I posted an example where adding
spaces looks like a good idea. So either make adding spaced configurable or
document the facts and mention that the user has to do an extra transformation
step before indexing his XML data, when he heeds extra spaces.

Mime
View raw message