Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <40300223.1040606@leverageweb.com>
Date: Sun, 15 Feb 2004 18:34:59 -0500
From: Geoff Howard <cocoon@leverageweb.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.5) Gecko/20031007
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: FileUploadManager
References: <5BDFE3A8-5DC1-11D8-95E3-000A95908E0E@wrinkledog.com>
 <402CA983.8080104@apache.org> <402D111E.4040104@leverageweb.com>
 <402FDF03.3020209@apache.org>
In-Reply-To: <402FDF03.3020209@apache.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Sylvain Wallez wrote:

> Geoff Howard wrote:
> 
>> Sylvain Wallez wrote:
>>
>>> Mark Lundquist wrote:
>>>
>>>> I've uploaded a corrected version of Nicolas Maisonneuve's  
>>>> FileUploadManager component, to:
>>>>     
>>>> http://wiki.cocoondev.org/attach?page=FileUploadsWithFlow%2Fcocoon- 
>>>> upload.jar
>>>>
>>>> ...and updated that Wiki page yet again, so I think it now gives 
>>>> the  Full Monty as far as uploading with Flow.  I also cleaned up 
>>>> some of  the other upload pages.
>>>>
>>>> Thanks to Geoff Howard and Bert van Kets for helping to get this  
>>>> working.
>>>>
>>>> This has turned into quite a recipe here on the Wiki page, and the  
>>>> "example" upload manager class seems good enough for general use.  
>>>> Is  there any reason why this component and its configuration should 
>>>> not be  added to Cocoon?
>>>
>>> Sorry, but this what this upload manager does is only copy a file. 
>>> What's the need of having yet another component for this?
>>
>> I'm -0 on this particular component as is, but am not quite sure which 
>> other components usable from flow with uploaded files are available as 
>> alternatives.  Which are you referring to?
> 
> Do we need a component at all? We have the CopySourceAction that does an 
> equivalent job (if you copy an "upload:" to another source), and we 
> could wrap it into a JS utility library.

Well, I am working on the philosophy that use of actions should be 
increasingly discouraged in favor of flow.  Since calling actions from 
flow is unnatural at best, I'd rather refactor the copy source action to 
  use some common helper class/component which could also be useful from 
flow.  (BTW, totally agreed that the general purpose idea in this case 
is copying one source to another - very powerful)

Since there is already a well known example in the wiki depicting file 
uploads with a mythical UploadManager component, I have felt that it 
would make sense to introduce such a thing in reality so we don't get so 
many repeated questions about how to handle file uploads in Cocoon.

In fact, in general I would like to see many of the useful actions 
refactored into general use components for simple use from flow. 
Currently there is not as much that feels simple for newbies to do from 
within flow script so they are using actions, transformers, and even xsp 
with side effects (!) to do what they need.

> Also, the Woody upload widget has currently no binding, and we could 
> write one that copies the uploaded file somewhere to another source.

Sounds good, but I need to look into the upload widget before commenting.

What people are saying is that the very basic need of uploading a file 
into a directory is not brain-dead simple and probably should be.

Geoff