cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Rolappe" <m_rola...@web.de>
Subject AW: redirect handling, environment handling, etc.
Date Thu, 19 Feb 2004 13:24:26 GMT


> -----Ursprungliche Nachricht-----
> Von: dev-return-55872-m_rolappe=web.de@cocoon.apache.org
> [mailto:dev-return-55872-m_rolappe=web.de@cocoon.apache.org]Im Auftrag
> von Carsten Ziegeler
> Gesendet: Donnerstag, 19. Februar 2004 14:08
> An: dev@cocoon.apache.org
> Betreff: RE: redirect handling, environment handling, etc.
>
>
> Unico Hommes wrote:
> >
> > Marco Rolappe wrote:
> > >
> > > ;-)
> > >
> > > the problems to be solved are the problems described: missing
> > > processing key check, missing start/endProcessing around
> > > ForwardEnvironment, storing the process key in the environment's
> > > object model, etc.
> > >
> >
> The mssing processing key check is intentionally. If startProcessing()
> is called twice on the same environment something is obviously wrong.

yeah, it's wrong but you wouldn't know.

> Unfortunately, an internal request/environment gets a copy of
> the parent object model, so it also gets the key in it's copy.
> So, in this case startProcessing() is legal and *must* overwrite
> the key stored in the object model.

but then I can't see the real point in protecting the environment processing
by a key. why not binding resource looked up/used while processing/to be
cleaned up to the actual environment then?

> > This is the approach taken in the 2.2 code base. Perhaps when
> > that code grows up it can be ported to 2.1 module as well.
> > Carsten can tell you more about that though.
> >
> The 2.2 code base is in many aspects much cleaner and also understandable
> (I hope) than 2.1.x. There are still some pieces to clean up, but we
> hope to do this in the next weeks.
> But one thing still remains: the processing key is stored in the object
> model.
> It's easy, fast and works. However, if someone has a better idea, I
> would be very happy as I don't want to put anything of that sort into
> the object model.

what about an environment attribute (I see that *EnvironmentWrapper also
delegates this to the wrapped environment, though)?

> In this aspect 2.2 is much better as only the key is stored in the object
> model,
> everything else is stored not reachable from either the environment or the
> object model. So, it's much cleaner and safer.

with everything else you mean request, response, ... objects? I guess I'm
going to take a look... ;-)


Mime
View raw message