cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Unico Hommes" <Un...@hippo.nl>
Subject RE: [IMP] Code Freeze (was: End of code freeze)
Date Wed, 11 Feb 2004 20:48:14 GMT

Joerg Heinicke wrote:
> 
> 
> On 11.02.2004 16:42, Unico Hommes wrote:
> 
> > Yeah, the confusion with the memory bug was partly due to me. After 
> > your original fix that still had a problem with the reader I 
> > introduced the bug again when I tried to fix that.
> 
> So the lastconsumer null test really works, you only broke it 
> with your 
> reader fix. I guess you have to stand a beer to Carsten :)
> 
> And we all have not reviewed the patch correctly as the 
> problem is obvious:
> 
> if (lc == null) {
>    lc = anObject;
> }
> 
> if (lc != null) {
>    //always true
>    //executing code introducing memory leak in special cases
> }

Exactly it. I have to plead guilty. It's not too bad though, I'd gladly
buy Carsten a beer :-D

Unico

Mime
View raw message