cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 26754] - "ModuleHelper is not setup correctly." when a page using the input logicsheet is called twice
Date Sat, 07 Feb 2004 14:15:27 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26754>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26754

"ModuleHelper is not setup correctly."  when a page using the input logicsheet is called twice

lmorandini@ieee.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ModuleHelper is not setup   |"ModuleHelper is not setup
                   |correctly. when the  input  |correctly."  when a page
                   |logicsheet is called twice  |using the input logicsheet
                   |                            |is called twice



------- Additional Comments From lmorandini@ieee.org  2004-02-07 14:15 -------
Geoff Howard:
Basically, the XSPModuleHelper was changed so that it assumed it needed to be
setup() again before each use.  Probably the right assumption, but does not
appear to have been assumed before and input.xsl was not changed accordingly. 
Because there is no sample using input.xsl, this was only noticed by people who
use the input module logicsheet and attempted to use 2.1.3.

The following simple patch fixes the problem:

Index: input.xsl
===================================================================
RCS file:
/home/cvs//cocoon-2.1/src/java/org/apache/cocoon/components/language/markup/xsp/java/input.xsl,v
retrieving revision 1.1
diff -u -r1.1 input.xsl
--- input.xsl    9 Mar 2003 00:08:56 -0000    1.1
+++ input.xsl    7 Feb 2004 13:29:12 -0000
@@ -79,8 +79,8 @@
         // create module cache
         if (this._xsp_module_helper == null) {
            this._xsp_module_helper = new XSPModuleHelper();
-           this._xsp_module_helper.setup(manager);
         }
+        this._xsp_module_helper.setup(manager);
       </xsp:init-page>

       <xsp:exit-page>

Mime
View raw message