Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 8968 invoked from network); 27 Jan 2004 15:52:50 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 27 Jan 2004 15:52:50 -0000 Received: (qmail 21291 invoked by uid 500); 27 Jan 2004 13:42:46 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 21205 invoked by uid 500); 27 Jan 2004 13:42:45 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 21184 invoked from network); 27 Jan 2004 13:42:45 -0000 Received: from unknown (HELO mail.s-und-n.de) (212.8.217.2) by daedalus.apache.org with SMTP; 27 Jan 2004 13:42:45 -0000 Received: from notes.sundn.de (ntsrv5.sundn.de [10.10.2.10]) by mail.s-und-n.de (postfix) with ESMTP id 0A8E619F5EB for ; Tue, 27 Jan 2004 14:42:34 +0100 (CET) Received: from hw0386 ([10.10.2.42]) by notes.sundn.de (Lotus Domino Release 6.5) with SMTP id 2004012714384012-37035 ; Tue, 27 Jan 2004 14:38:40 +0100 From: "Carsten Ziegeler" To: Subject: RE: source resolving in 2.2 Date: Tue, 27 Jan 2004 14:44:09 +0100 Message-ID: MIME-Version: 1.0 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <84F0A43A4248CE45B5C0E20F4C40779C600B49@naomi.webworks.nl> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 Importance: Normal X-MIMETrack: Itemize by SMTP Server on PBSN1/Systeme und Netzwerke(Release 6.5|September 26, 2003) at 27.01.2004 14:38:40, Serialize by Router on PBSN1/Systeme und Netzwerke(Release 6.5|September 26, 2003) at 27.01.2004 14:38:41, Serialize complete at 27.01.2004 14:38:41 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Unico Hommes wrote: > OK thanks. It looks like we had the same idea :-). I went ahead and > implemented it the way you describe in option b) . I also added two > static helper methods to EnvironmentHelper: getSourceResolver and > getRedirector so we don't have to pass in the processor instance. Good! > > If you find the time perhaps you can proof-read the changes? > Looks ok to me, I just changed it :) I added the Environment as an parameter to the methods to avoid one lookup. Carsten