Return-Path: 
 <dev-return-53921-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 72506 invoked from network); 12 Jan 2004 12:28:54 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 12 Jan 2004 12:28:54 -0000
Received: (qmail 13272 invoked by uid 500); 12 Jan 2004 12:28:49 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 13231 invoked by uid 500); 12 Jan 2004 12:28:48 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 13215 invoked from network); 12 Jan 2004 12:28:48 -0000
Received: from unknown (HELO naomi.webworks.nl) (24.132.161.79)
  by daedalus.apache.org with SMTP; 12 Jan 2004 12:28:48 -0000
X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0
content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: cvs commit: cocoon-2.1/tools/targets ide-build.xml
Date: Mon, 12 Jan 2004 13:28:47 +0100
Message-ID: <84F0A43A4248CE45B5C0E20F4C40779C600ADE@naomi.webworks.nl>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: cvs commit: cocoon-2.1/tools/targets ide-build.xml
Thread-Index: AcPW4ZTngwMdhRABQeCgaGn/ArpIHQAlOiZA
From: "Unico Hommes" <Unico@hippo.nl>
To: <dev@cocoon.apache.org>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N



Joerg Heinicke wrote:
>=20
>=20
> On 09.01.2004 14:06, unico@apache.org wrote:
>=20
> > unico       2004/01/09 05:06:13
> >=20
> >   Modified:    tools/targets ide-build.xml
> >   Log:
> >   also remove class files from WEB-INF when preparing to run Jetty
> > inside eclipse
>=20
> But doesn't this break unnecessarily the starting of Jetty without
> Eclipse? *If* you use Eclipse you can change the output directory of=20
> compiling to another directory (default is=20
> build/eclipse/classes). *If*=20
> you do *not* use Eclipse for servlet container startup you=20
> need either=20
> libs or classes.
>=20
> I would like to have this commit reverted. WDYT?
>=20

Yes, executing this target does break running Jetty without Eclipse, but
it was already doing that before my change :-)

The target is intended to be used only when running Jetty inside of
Eclipse so that Jetty will use the Eclipse project classpath without
overiding it with the one it loads from WEB-INF/lib and WEB-INF/classes.
You couldn't have used this target with the scenario you describe
previous to the below change either. Where would Jetty have loaded the
third party dependencies from?

The reason for the below change is that currently the build system seems
to copy all *.samples.* classes there. And so these get in the way of
their equivalents inside Eclipse project classpath.

Unico

> Joerg
>=20
> >      <target name=3D"eclipse-webapp-delete-jars" =
depends=3D"prepare">
> >   -      <!-- delete all jars, they are already included in=20
> the project -->
> >   +      <!-- delete all jars and class files, they are=20
> already included in the project -->
> >          <delete>
> >   -          <fileset dir=3D"${build.webapp}/WEB-INF/lib"=20
> includes=3D"*.jar"/>
> >   +          <fileset dir=3D"${build.webapp}/WEB-INF">
> >   +            <include name=3D"lib/*.jar" />
> >   +            <include name=3D"classes/**/*.class" />
> >   +          </fileset>
> >          </delete>
> >      </target>
>=20
>=20