cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 26138] - [PATCH] [i18n] Updated XMLResourceBundel, XMLResourceBundleFactory to detect changes in underlying file and reload it
Date Fri, 16 Jan 2004 15:54:39 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26138>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26138

[PATCH] [i18n] Updated XMLResourceBundel, XMLResourceBundleFactory to detect changes in underlying
file and reload it

kot_p@hotbox.ru changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From kot_p@hotbox.ru  2004-01-16 15:54 -------
Applied to 2.1-dev.
Please crosscheck and confirm.

Though, this patch solves only the half of the problem, because I18nTransformer 
still returns an cache validity object which doesn't take into account the 
underlying bundle's validity.
E.g.: if you request a page and then modify the translation, you won't get the 
same page with a new translation. But all the other (not requested previously) 
pages will display the new translation.

The following method should be corrected:

    /**
     * Implementation of CacheableProcessingComponent.
     * Generates validity object for this transformer or <code>null</code>
     * if this instance is not cacheable.
     */
    public SourceValidity getValidity() {
        // FIXME (KP): Cache validity should be generated by
        // Bundle implementations.
        return 
org.apache.excalibur.source.impl.validity.NOPValidity.SHARED_INSTANCE;
    }

Mime
View raw message