cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 25517] - [PATCH] module source
Date Mon, 15 Dec 2003 14:39:36 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25517>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25517

[PATCH] module source

vgritsenko@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[Patch] module source       |[PATCH] module source



------- Additional Comments From vgritsenko@apache.org  2003-12-15 14:39 -------
Nice!

Couple of things to change:
1) Kill those TABs! That's one of the really short list of code conventions here
2) selector.release(inputModule) and manager.release(selector) should be in finally
3) Typo "could nor be serialized" :)
4) Does it make sense to add support for XMLizable and DOM Nodes (to kill
ReadDOMSessionTransformer / WriteDOMSessionTransformer /
SessionAttributeGenerator)? Or it sould better be just another source?

Vadim

Mime
View raw message