Return-Path: 
 <dev-return-52240-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 78984 invoked from network); 30 Nov 2003 13:31:19 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 30 Nov 2003 13:31:19 -0000
Received: (qmail 80629 invoked by uid 500); 30 Nov 2003 13:31:14 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 80367 invoked by uid 500); 30 Nov 2003 13:31:13 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 80354 invoked from network); 30 Nov 2003 13:31:12 -0000
Received: from unknown (HELO exchange.sun.com) (192.18.33.10)
  by daedalus.apache.org with SMTP; 30 Nov 2003 13:31:12 -0000
Received: (qmail 23561 invoked by uid 50); 30 Nov 2003 13:31:23 -0000
Date: 30 Nov 2003 13:31:23 -0000
Message-ID: <20031130133123.23560.qmail@nagoya.betaversion.org>
From: bugzilla@apache.org
To: dev@cocoon.apache.org
Cc: 
Subject: DO NOT REPLY [Bug 25093] New:  -
    [PATCH] Defaults input module does not allow empty values
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25093>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25093

[PATCH] Defaults input module does not allow empty values

           Summary: [PATCH] Defaults input module does not allow empty
                    values
           Product: Cocoon 2
           Version: Current CVS 2.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: general components
        AssignedTo: dev@cocoon.apache.org
        ReportedBy: Alfred.Nathaniel@swx.com


With a cocoon.xconf entry such as

  <component-instance 
class="org.apache.cocoon.components.modules.input.DefaultsModule" name="my">
    <values>
      <foo></foo>
    </values>
  </component-instance>

Cocoon does not start anymore.  The reason is that 
avalon.framework.Configuration considers the value as undefined (rather than 
the empty string), and config.getValue() throws a ConfigurationException.

In the Cocoon sitemap {my:foo} is evaluated to the empty string, if <foo> is 
not defined at all in <values>.  It should do the same, if <foo> is defined but 
with empty value.

Patch:

===================================================================
RCS file: /home/cvspublic/cocoon-
2.1/src/java/org/apache/cocoon/components/modules/input/DefaultsModule.java,v
retrieving revision
diff -u -r1.2
--- cocoon-
2.1/src/java/org/apache/cocoon/components/modules/input/DefaultsModule.java
	2003/03/20 07:31:51	1.2
+++ cocoon-
2.1/src/java/org/apache/cocoon/components/modules/input/DefaultsModule.java
	2003/11/30 12:32:52
@@ -87,7 +87,7 @@
         this.constants = new HashMap();
         Configuration[] consts = config.getChild("values").getChildren();
         for (int i=0; i<consts.length; i++) {
-            this.constants.put(consts[i].getName(), consts[i].getValue());
+            this.constants.put(consts[i].getName(), consts[i].getValue(""));
         }
     }