cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Larson <timlarsonw...@yahoo.com>
Subject Re: [Woody patch] Class, New, Struct, and Union widgets
Date Fri, 21 Nov 2003 18:43:50 GMT
--- Sylvain Wallez <sylvain@apache.org> wrote:
> Timothy Larson wrote:
> >A diff adding Class, New, Struct, and Union widgets to Woody is at:
> >  http://wiki.cocoondev.org/Wiki.jsp?page=TimLarson
...
> Looks definitely interesting, but seem to have required a lot of 
> refactoring. Can you please explain why?

Most of the refactoring is not really "required".
It was part of a (possibly misguided) attempt to abstract most of the
widget code into common classes.  If you look through the widget code
(widgets, definitions, and builders) you will see a lot of duplicate or
nearly duplicate code.  I initially modified all of that code, shrinking
the code for each widget to only what made each type of widget different,
with the rest of the code abstracted.

This made for too drastic a patch to submit all at once, so I scaled it
back to where the abstract code was still present (so we could discuss it),
but only the most essential changes were made to the existing widgets to
support the four new widget types.

I do not want or expect this patch to be commited as is, but rather be
torn apart, discussed, modified, and have the most useful parts commited.

--Tim Larson

> I'll take a deeper look at this ASAP.

Thanks for looking at it.

--Tim Larson


__________________________________
Do you Yahoo!?
Free Pop-Up Blocker - Get it now
http://companion.yahoo.com/

Mime
View raw message