Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 3115 invoked from network); 24 Oct 2003 16:25:52 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 24 Oct 2003 16:25:52 -0000 Received: (qmail 40602 invoked by uid 500); 24 Oct 2003 16:25:42 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 40454 invoked by uid 500); 24 Oct 2003 16:25:41 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 40441 invoked from network); 24 Oct 2003 16:25:41 -0000 Received: from unknown (HELO onramp.i95.net) (205.177.132.17) by daedalus.apache.org with SMTP; 24 Oct 2003 16:25:41 -0000 Received: from apache.org ([66.208.12.130]) by onramp.i95.net (8.12.10/8.12.9) with ESMTP id h9OGPg8M030118 for ; Fri, 24 Oct 2003 12:25:42 -0400 Message-ID: <3F995286.1030603@apache.org> Date: Fri, 24 Oct 2003 12:25:42 -0400 From: Berin Loritsch User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: Mass update to components for Cocoon 2.2 References: <84F0A43A4248CE45B5C0E20F4C40779C667C4D@naomi.webworks.nl> <3F970ABA.9000601@leverageweb.com> In-Reply-To: <3F970ABA.9000601@leverageweb.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Geoff Howard wrote: > Unico Hommes wrote: > >> Ok, I am running into the following situation: Looking at >> components.modules.input.AbstractMetaModule it defines that it is >> Composable and assigns the component manager to a protected member >> variable. A subclass, ChainMetaModule, uses the component manager to >> lookup a dependency. This means ChainMetaModule should redefine the >> compose()/ (->service()) method in order to declare its dependencies. We should migrate to ServiceManager throughout. It really isn't that hard to do, and in fact, in most places in 2.2 it has already been done. >> >> So, in order to avoid this I'd like to put the dependency tags above at >> class declaration level instead of directly above the service() method. >> Can I do this? No. Well, I should be more clear and say, "You can, but they won't be read". > And while you're at it can you confirm whether or not tags are inherited > by subclasses? You know, I can't remember off the top of my head. Let's add the Fortress meta info collection task to the ANT build, and try it. If it does attempt to inherit dependencies, then there are certain caveats. You shouldn't expect it to find something in another JAR for instance. I will say that it is a step in the right direction, but it is not perfect yet. -- "They that give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." - Benjamin Franklin