cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <>
Subject Re: ResolverImpl test case broken again?
Date Fri, 10 Oct 2003 08:31:50 GMT
Ugo Cei wrote:
> David Crossley wrote:
> > I tested your patch and that works fine on my system.
> > Well done, i believe that you have fixed it. Would you please commit.
> I'll do this ASAP.
> > So we can leave the resolver test cases there until we find something
> > better to do with them. We really need to clean up all of the testcases.
> Having slept over the issue (not much, just a little more than 4 hours 
> :-(), these are my thoughts:
> We should strive for 100% test coverage. Removing a test case without 
> removing the class being tested is no good, in my book.
> Should we remove the ResolverImpl class? As far as I can see, it's not 
> used anywhere in our codebase, apart from the test case. On the other 
> hand, it's not @deprecated, even though it implements a deprecated 
> interface. Should we call a vote on the issue?

If no-one says anything in the next few days, then i will remove the
resolver testcases. They served their purpose here in Cocoon while
developing the entity-resolver stuff, to ensure that it worked on
all platforms.


View raw message