Return-Path: 
 <dev-return-48243-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 88639 invoked from network); 26 Sep 2003 12:28:12 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 26 Sep 2003 12:28:12 -0000
Received: (qmail 11151 invoked by uid 500); 26 Sep 2003 12:28:05 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 11094 invoked by uid 500); 26 Sep 2003 12:28:05 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
list-post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 11071 invoked from network); 26 Sep 2003 12:28:04 -0000
Received: from unknown (HELO otsrv1.iic.rug.ac.be) (157.193.121.51)
  by daedalus.apache.org with SMTP; 26 Sep 2003 12:28:04 -0000
Received: from yum.ot (host100 [192.168.123.100])
	by otsrv1.iic.rug.ac.be (8.11.6/8.11.6) with ESMTP id h8QCS4X18238
	for <dev@cocoon.apache.org>; Fri, 26 Sep 2003 14:28:04 +0200
Subject: Re: Event handling in Woody
From: Bruno Dumon <bruno@outerthought.org>
To: dev@cocoon.apache.org
In-Reply-To: <3F73FFD6.6050808@anyware-tech.com>
References: <3F6A27D8.4010506@anyware-tech.com>
	 <3F6ACFFD.7020400@outerthought.org> <3F6B0466.4050403@anyware-tech.com>
	 <3F6B1F2D.1010704@outerthought.org> <3F6B2977.5010005@anyware-tech.com>
	 <3F6B7D3E.7000402@outerthought.org> <3F6C4D27.1040602@anyware-tech.com>
	 <3F720150.6090208@outerthought.org>  <3F73FFD6.6050808@anyware-tech.com>
Content-Type: text/plain
Organization: Outerthought
Message-Id: <1064578946.25245.232.camel@yum.ot>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4 
Date: Fri, 26 Sep 2003 14:22:26 +0200
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

On Fri, 2003-09-26 at 10:59, Sylvain Wallez wrote:
> TO ALL:
> I invite you to look at the "Various", "Flowscript" and "Car selector" 
> Woody samples in the latest CVS. These demonstrate the styling and 
> event-handling features I added to Woody, and I'd be interested in 
> having feedback on this.

No time to look in detail at it right now, but I noticed a little
problem with the car selector: if I select a make, type and model, and
then change the make again, it gives an exception.

<snip/>
> An noticeble thing, though : calling Field.getValue() _validates_ the 
> field's value, meaning that even if the whole form should not be 
> validated, local validation messages can appear, related to the event 
> handlers that have been triggered. This gives some useful feedback to 
> the user when an intra-form action cannot be performed because the 
> fields used by this action are invalid.

Hmmm, wouldn't it then be better to add an isValid() method to the
Widget interface? I think it's best if getValue() simply returns the
value, and doesn't cause any magic side-effects. Also, previously
getValue() returned the value of the widget even if it wasn't valid, and
the conversion from string to object was done in the readFromRequest()
method.

-- 
Bruno Dumon                             http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
bruno@outerthought.org                          bruno@apache.org