cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marc Portier <...@outerthought.org>
Subject Remove FormHandler? (was Re: cvs commit: cocoon-2.1/src/blocks/apples/java/org/apache/cocoon/components/flow/apples/samples BindingWoodyApple.java)
Date Thu, 25 Sep 2003 21:21:25 GMT
Carsten,

Fixed, and committing...

Motivation: Thx to the woody-event changes from Sylvain this sample can 
in fact remove all references to the (now old)FormHandler.


on a related matter:
I really would remove the class alltogether as it would trigger 
additional compile errors maybe in early adopters' apps resulting in 
people changing to the new way of event-handling sooner rather then 
later. (already pre 2.1.2 that is :-))

Or if this triggers an avalance of "Hey this and that isn't working any 
more" -mails then it might even yield the use-case(s) (see 
code-comments) we are looking for ;-)


regards,
-marc=

cziegeler@apache.org wrote:

> cziegeler    2003/09/24 15:21:07
> 
>   Modified:    src/blocks/apples/java/org/apache/cocoon/components/flow/apples/samples
>                         BindingWoodyApple.java
>   Log:
>   Fix compilation
>   
>   Revision  Changes    Path
>   1.4       +2 -1      cocoon-2.1/src/blocks/apples/java/org/apache/cocoon/components/flow/apples/samples/BindingWoodyApple.java
>   
>   Index: BindingWoodyApple.java
>   ===================================================================
>   RCS file: /home/cvs/cocoon-2.1/src/blocks/apples/java/org/apache/cocoon/components/flow/apples/samples/BindingWoodyApple.java,v
>   retrieving revision 1.3
>   retrieving revision 1.4
>   diff -u -r1.3 -r1.4
>   --- BindingWoodyApple.java	24 Sep 2003 21:26:51 -0000	1.3
>   +++ BindingWoodyApple.java	24 Sep 2003 22:21:07 -0000	1.4
>   @@ -148,7 +148,8 @@
>                formSource = resolver.resolveURI(formURI);
>                this.form = formManager.createForm(formSource);
>                formHandler = (FormHandler) this.makeInstance(formHandlerClassName);
>   -            formHandler.setup(this.form);
>   +            // FIX THIS
>   +            // formHandler.setup(this.form);
>                this.form.setFormHandler(formHandler);
>    
>                bindSource = resolver.resolveURI(bindURI);
>   
>   
>   

-- 
Marc Portier                            http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
Read my weblog at              http://radio.weblogs.com/0116284/
mpo@outerthought.org                              mpo@apache.org


Mime
View raw message