cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22498] - [PATCH] Bugs in configuration-handling in LuceneIndexTransformer
Date Tue, 19 Aug 2003 01:43:04 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22498>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22498

[PATCH] Bugs in configuration-handling in LuceneIndexTransformer

joerg.heinicke@gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From joerg.heinicke@gmx.de  2003-08-19 01:43 -------
Patch applied, thanks for the fix.

Comments:

What about "We don't need all this stuff" in line 188?

The null test in line 392 (atts != null) is useless, because one line earlier
atts is already accessed (atts.getIndex(LUCENE_URI,
LUCENE_ELEMENT_ATTR_TO_TEXT_ATTRIBUTE)). So either NPE in line 391 or no problem
:-) Should the null test be moved or can the NPE no longer happen. I guess the
first one ...

Please cross test.

Regards,

Joerg

Mime
View raw message