cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22173] - [PATCH] LDAPTransformer: patch collection
Date Mon, 18 Aug 2003 12:49:53 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22173>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22173

[PATCH] LDAPTransformer: patch collection





------- Additional Comments From yuryx@mobicomk.donpac.ru  2003-08-18 12:49 -------
> Many, many thanks for this work, Unico.
> I really appreciate your support at such a heavy task.

No problem :)

> Some issues:
> 1. What about lines 717 - 722 (code in comments)?
Yes, sorry, sorry!
> 2. What about lines 1436 - 1438 (unused method attribute())?

Don't know. Yuri?

No, this - for show/hide attribute node (name) from output xml (IMHO)

> 4. Yury used UTF-8, Unico has ISO-8859-1 in the accumulated patch => ... ?

I took a look at version 1.4 and noticed ln 1432:

// Changed by yuryx (encode string value to UTF characters from base encoding)
if ( !encoding.equals("ISO-8859-1")) {
  attrVal = new String(attrVal.getBytes("ISO-8859-1"),encoding);
  attrVal = new String(attrVal.getBytes(encoding),"UTF-8");
};
// end

This code is deprecated, because it wrong.

Mime
View raw message