cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 22173] - [PATCH] LDAPTransformer: patch collection
Date Thu, 07 Aug 2003 00:50:24 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22173>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22173

[PATCH] LDAPTransformer: patch collection

joerg.heinicke@gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yuryx@mobicomk.donpac.ru
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|[PATCH] LDAPTransformer     |[PATCH] LDAPTransformer:
                   |doesn't print multiple      |patch collection
                   |attribute results           |



------- Additional Comments From joerg.heinicke@gmx.de  2003-08-07 00:50 -------
Many, many thanks for this work, Unico. I really appreciate your support at such
a heavy task.

The patch is applied - seems to be a really huge one ;-)

Some issues:
1. What about lines 717 - 722 (code in comments)?
2. What about lines 1436 - 1438 (unused method attribute())?
3. I refactored the code for the recoding - I hope I did no mistake. Yury, can
you test it a bit more intensively :-) Does the naming LDAP_ENCODING,
recodeFromLDAPEncoding() and recodeToLDAPEncoding() make sense (i.e. do I
understand what should happen here)?
4. Yury used UTF-8, Unico has ISO-8859-1 in the accumulated patch => ... ?

Thanks again for the patches. Please cross-test.

Joerg

Mime
View raw message