Return-Path: Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 88825 invoked by uid 500); 6 Jul 2003 07:57:33 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@cocoon.apache.org Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 88805 invoked from network); 6 Jul 2003 07:57:32 -0000 Received: from mail.gmx.net (213.165.64.20) by daedalus.apache.org with SMTP; 6 Jul 2003 07:57:32 -0000 Received: (qmail 19122 invoked by uid 65534); 6 Jul 2003 07:57:43 -0000 Received: from Bd5a4.pppool.de (EHLO gmx.de) (213.7.213.164) by mail.gmx.net (mp009) with SMTP; 06 Jul 2003 09:57:43 +0200 Message-ID: <3F07D660.30508@gmx.de> Date: Sun, 06 Jul 2003 09:57:20 +0200 From: Joerg Heinicke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3.1) Gecko/20030425 X-Accept-Language: de-de, de, en-gb, en-us, en MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: dos2unix (Was: cvs commit: cocoon-2.1/.../poi/hssf/elements EPMerge.java) References: <20030705143317.26163.qmail@icarus.apache.org> <1057457175.26818.16968.camel@ighp> <1057457466.26817.16994.camel@ighp> In-Reply-To: <1057457466.26817.16994.camel@ighp> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N David Crossley wrote: > David Crossley wrote: > >>joerg@apache.org wrote: >> >>>joerg 2003/07/05 07:33:17 >>> >>> Modified: src/blocks/poi/java/org/apache/cocoon/components/elementprocessor/impl/poi/hssf/elements >>> EPMerge.java >>> Log: >>> clean up >>> line endings fixed >> >>The email diff showed something strange with the line endings after >>your "fix". What tool did you use to do that? Anyway it did not work. >>I use 'dos2unix' on a Linux platform. > > > By the way, i reverted the changes and fixed the line endings again. > However your log message also says "clean up" ... i cannot see what > else was changed, so such revisions were lost. > > --David Hmm, sorry, I "found" the file, because Eclipse gave me a warning in the package explorer although the poi block was already "clean". Opening the file after every line there was an empty line. I did a code formatting, which seemed to fix the line endings, but I guess I should have done an explicit converting (normally I use UltraEdit for this). The clean up was an unused variable, that also caused the warning. Sorry for breaking the file even more and thanks for the fixing :) Joerg