cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Michels <step...@apache.org>
Subject Re: [Vote] Controller/Sitemap integration
Date Thu, 17 Jul 2003 08:55:10 GMT


On Thu, 17 Jul 2003, Joerg Heinicke wrote:

> Stephan Michels wrote:
>
> > <map:flows>
> >  <map:flow name="js" type="javascript">
> >   <script src="flow/PetStoreImpl.js"/>
> >   <script src="flow/petstore.js"/>
> >  </map:flow>
> >  <map:flow name="java" type="atct" class="org.apache.cocoon...."/>
> >  <map:flow name="fsm" type="fsm" src="descriptors/fsm.xml"/>
> > </map:flows>
> >
> > So this will be coherent with the other objects.
>
> Which leads the sentence "This reflects that the flow is not a *usual*
> sitemap resource but something else." ad absurdum :)

Okay, but how should a different implemenation look like?

> >>  [B] The controller is called by:
> >>
> >>      <map:call flow="[yourFlow]">
> >>        <map:parameter name="x" value="y"/>
> >>      </map:call>
> >
> >
> > Seems fine, an alternative will be
> >
> > <map:initiate flow="js" call="[Javascript function]">
> >  <map:parameter name="x" value="y"/>
> > </map:initiate>
> >
> > <map:initiate type="java" call="[Java method]">
> >  <map:parameter name="x" value="y"/>
> > </map:call>
> >
> > <map:initiate type="fsm" call="[Name of state]">
> >  <map:parameter name="x" value="y"/>
> > </map:initiate>
> >
> > I like the combination of initiate/continue
>
> initiate/continue is ok, but what about keeping syntax of all sitemap
> objects using @type and @src:
>
> <map:initiate type="java" src="[Java method]"/>
>
> Or is it to far away from the sense or even misleading?

+1

> >>  [C] A state of the controller is called by:
> >>
> >>	<map:call state="">
> >>        <map:parameter name="x" value="y"/>
> >>     </map:call>
> >
> >
> > We don't call states in this sense. We continue
> > a continuation ;-)
> > I guess <map:continue continuation="{1}"/> is bad.
> >
> > <map:continue src="{1}"/>
> > or
> > <map:continue id="{1}"/>
>
> Same like above, so I prefer @src.

+1

> >>      - rename "WebContinuation" to "FlowState", and accordingly
> >>        "WebContinuationManager" to "FlowStateManager".
>
> Here I prefer the States for the reasons Marc provided, so +1 here.

+0

> Conal Tuohy wrote:
> > What about <map:continue from="..."/>
>
> Hmm, I don't really like it. We don't need an English sentence :)
>
> Otherwise you could also change to <map:generate from="foo.xml"/>,
> <map:transform with="bar.xsl"/> and <map:serialize as="html"/>. @type
> and @src is a good abstraction IMO.

I think in the same direction, @src and @type are more intuitive.

Stephan.




Mime
View raw message