cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@s-und-n.de>
Subject RE: Re: cvs commit: cocoon-2.1/src/java/org/apache/cocoon/components/treeprocessor/sitemap SwitchSelectNode.java
Date Wed, 30 Jul 2003 08:24:15 GMT
Volker Schmitt wrote:
> Anyway, I think I found the real bug and it is in the ExceptionSelector
> line 185:
>
> public boolean select(String expression, Object selectorContext) {
>     // Just compare the expression with the previously found name
>     boolean result = expression.equals
> (((FindResult)selectorContext).getName()); // line 185
>
> As you described above it is the responsibility of the Selector and the
> ExceptionSelector throws a NullPointerException if the selectorContext is
> null. So I think we need to add a
> if (selectorContext == null)
>       return false;
>
Added.

>
> Carsten, do you remember, what the difference is between
> "JXPathExceptionSelector" and "XPathExceptionSelector". I think
> JXPathExceptionSelector is an old version of
> XPathExceptionSelector and can
> not work because of line 132:
> String exceptionName =
>       (String) super.getSelectorContext(objectModel, parameters);
> getSelectorContext() returns an FindResult Object not a String, so I think
> it can't work. I think we can remove it.

Removed.

Carsten


Mime
View raw message