cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Upayavira" ...@upaya.co.uk>
Subject Re: [CLI] [PATCH] Set exit status, modified print statements
Date Sun, 20 Jul 2003 18:45:37 GMT
Jeff,

Your changes look great. All make sense - you've got my go-ahead.

I particularly like the broken link 'X'. And I'm pleased you were able to
work out my BeanListener code :-)

Regards, Upayavira

On Sun, 20 Jul 2003 21:34:14 +1000, "Jeff Turner" <jefft@apache.org>
said:
> Attachment _really_ attached this time.
> 
> While I'm spamming people's mailboxes.. here's what a broken page looks
> like with the patch:
> 
> ...
> * [0] skin/images/tab-left.gif
> X [0] samples/ihtml-sample.html BROKEN: null
> * [0] samples/wiki-sample.pdf
> ...
> Total time: 0 minutes 40 seconds
> 
> BUILD FAILED
> /home/jeff/apache/xml/xml-forrest/build/dist/shbat/forrest.build.xml:604:
> Java returned: 1
> 
> These changes are mainly to make command-line Cocoon useable from within
> cron scripts, where the exit code is now useful, and broken URIs can be
> obtained with "grep ^X | cut -d\  -f 3".
> 
> 
> --Jeff
> 
> On Sun, Jul 20, 2003 at 08:59:14PM +1000, Jeff Turner wrote:
> > I thought I'd ask before applying the attached patch to Main.java.  It
> > does the following:
> > 
> >  - Checks if there are any broken links, and if so, does a System.exit(1)
> >    instead of System.exit(0).
> > 
> >  - Print an error message at the point the broken link occurs, in
> >    addition to listing it in the brokenlinks file.  I don't want to have
> >    to wait 10 mins to discover if there's a broken link :)
> > 
> >  - Throw out the code that wraps log output at 67 chars.  My terminal is
> >    a good deal wider than 67 chars, and in any case is able to handle
> >    wrapping itself :)
> > 
> > 
> > --Jeff

Mime
View raw message