cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kavanagh <...@dotech.com>
Subject Re: AbstractSAXTransformer logging (Re: cvs commit: ... AbstractSAXTransformer.java)
Date Wed, 18 Jun 2003 13:33:51 GMT
Yes, yes, remove this stuff! I'll know if the hooks are being called if I
a) use the right namespace
b) override the hooks methods.
I'm sure these were helpful at one point, but now....

David

Carsten Ziegeler wrote:

>Jeff Turner wrote:
>  
>
>>I'm not too sure of this commit.  The problem is that
>>AbstractSAXTransformer's
>>debug-level logging is so verbose that it swamps the debug logs
>>of its children
>>with stuff like this:
>>
>>DEBUG   (/forrest/body-index.html): BEGIN endTransformingElement
>>uri=, name=link, raw=link)
>>DEBUG   (/forrest/body-index.html): END endTransformingElement
>>DEBUG   (/forrest/body-index.html): BEGIN endTransformingElement
>>uri=, name=p, raw=p)
>>DEBUG   (/forrest/body-index.html): END endTransformingElement
>>...
>>
>>Simplest solution would be to just remove those debug() statements.
>>
>>However, assuming these logs are useful to someone, I've added a
>>flag to switch
>>them on/off (left on by default).  The flag is declared 'final' and can be
>>switched off with the protected constructor added for this purpose.
>>
>>Advice welcome.
>>
>>    
>>
>I like this idea, but how can you turn this off? The default constructor
>is automatically called by avalon.
>PS: I have no objection in making "off" the default.
>
>Carsten
>  
>


Mime
View raw message