cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Haul <>
Subject Re: Unresolved bugs with patches
Date Tue, 03 Jun 2003 20:23:26 GMT
Torsten Knodt wrote:
> CH> > 20297 [PATCH] Added RequestURI in addition to SitemapURI to BaseLi
> CH> > -> no opinion: Christian?
> CH> won't fix -- module is deprecated and duplicates functionality of the
> CH> RequestInputModule
> Sure? BaseLink returnes something like ../../ to have a link back to the base. 
> Where is this stored in the request? I created this module, because I 
> couldn't find it in the request. It only calculates it's values based on 
> values from the request.

Torsten, I'm sorry :-(

I have only skimmed over your patch and have missed the loop 
constructing the String. Although I would personally use absolute links 
in those cases I accept that in some situations relative links are 
preferable. So I appologize for misjudging the patch.

Will accept the patch tomorrow.

Thanks for spotting the mistake!


C h r i s t i a n       H a u l
     fingerprint: 99B0 1D9D 7919 644A 4837  7D73 FEF9 6856 335A 9E08

View raw message