cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 9835] - Nested actions in action-sets do not execute
Date Sat, 14 Jun 2003 18:51:58 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9835>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9835

Nested actions in action-sets do not execute





------- Additional Comments From javageoff@yahoo.com  2003-06-14 18:51 -------
I'm not the best person to help here (understatement) but I'm wanting to take a 
crack since no one seems to want to touch this and it's *supposed* to block 2.1 
release which may be coming up.  Also, I've always wanted to figure out how the 
TreeProcessor works.

It seems to me that nested actions in action-sets are not "not working" but 
completely un-implemented in the TreeProcessor.  Lines 90-101 of 
ActionSetNodeBuilder have: 
            if ("act".equals(name)) {

                checkNamespace(childConfig);
                String type = this.treeBuilder.getTypeForStatement(childConfig, 
Action.ROLE + "Selector");

                actionTypes.add(type);
                actionNames.add(childConfig.getAttribute("action", null));
                actionSources.add(VariableResolverFactory.getResolver(
                    childConfig.getAttribute("src", null), this.manager));
                actionParameters.add(this.getParameters(childConfig));

            } else {

which seems to imply that it is expecting a linear list of "act" children 
of "action-set" and makes no provision for nested actions.  I don't really see 
right off how to implement this nesting since the action set is not using the 
tree processor for handling children of action-set - it's just using an 
ArrayList - and passing ActionSetNode an array.  Anyone who knows the 
treeprocessor well enough care to give a clue about how to proceed adding this?

What about allowing action-set to recursively call other action sets.  Would 
that work or is that evil?

I need to ask: was this intentionally handled in the compiled sitemap, or did 
it just accidentally work?  I'm trying to get at whether this was 
an "officially supported" feature and needs to be handled for backwards 
compatibility.

Geoff Howard

Mime
View raw message