Return-Path: 
 <cocoon-dev-return-42458-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org
Received: (qmail 80500 invoked by uid 500); 20 May 2003 19:40:15 -0000
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:cocoon-dev-help@xml.apache.org>
list-unsubscribe: <mailto:cocoon-dev-unsubscribe@xml.apache.org>
list-post: <mailto:cocoon-dev@xml.apache.org>
Reply-To: cocoon-dev@xml.apache.org
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 80479 invoked from network); 20 May 2003 19:40:14 -0000
Received: from horkos.telenet-ops.be (195.130.132.45)
  by daedalus.apache.org with SMTP; 20 May 2003 19:40:14 -0000
Received: from localhost (localhost.localdomain [127.0.0.1])
	by horkos.telenet-ops.be (Postfix) with SMTP id 8E258841BA
	for <cocoon-dev@xml.apache.org>; Tue, 20 May 2003 21:40:19 +0200 (CEST)
Received: from [192.168.123.102] (D5E00128.kabel.telenet.be [213.224.1.40])
	by horkos.telenet-ops.be (Postfix) with ESMTP id 24EC78411A
	for <cocoon-dev@xml.apache.org>; Tue, 20 May 2003 21:40:19 +0200 (CEST)
Subject: Re: [PATCH] I18nTransformer decimal and grouping locale
From: Bruno Dumon <bruno@outerthought.org>
To: cocoon-dev@xml.apache.org
In-Reply-To: <001601c31efc$97119690$c8eb14ac@kot>
References: <20030520155514.22182.qmail@nagoya.betaversion.org>
	 <001601c31efc$97119690$c8eb14ac@kot>
Content-Type: text/plain
Organization: Outerthought
Message-Id: <1053459441.29909.129.camel@yum.ot>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 
Date: 20 May 2003 21:37:22 +0200
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Tue, 2003-05-20 at 20:20, Konstantin Piroumian wrote:
> Don't want to reopen this path, so replying to this message.
> 
> IMO, adding attributes for this kind of special cases is not a very good
> idea.
> It would be much better to define something like a <number-format/> or
> <currency-format /> element where you could define anything you need, e.g.:
> 
> <currency-format name="germans-for-americans>
>   <pattern>0.00##</pattern>
>   <decimal-separator>.</decimal-separator>
>   <group-separator>,</group-separator>
> </currency-format>
> 
> or something like this. And then use it with <i18n:currency/>:
> 
> <i18n:number type="currency" src-locale="en" format="germans-for-americans"
> value="27.24"/>

The i18n:number element already supports attributes such as pattern and
fraction-digits. It seems then only logical to also add 
decimal-seperator and group-seperator attributes. Adding a feature to
define reusable formats, like you propose above, is a different thing.

However, the knowledge of what the decimal-separtor and group-seperator
are for a certain locale is already present in the JRE for a large
number of locales. Why not reuse that as the dec-and-grp-locale
attribute is doing? Otherwise you'd have to define germans-for-* formats
for all countries in which you are selling.

One thing that on second sight seems less than ideal though is the name
of the "dec-and-grp-locale" attribute. Something like
"separators-locale" would be more readable.

-- 
Bruno Dumon                             http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
bruno@outerthought.org                          bruno@apache.org