cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Upayavira">
Subject Re: Cocoon CLI broken
Date Tue, 27 May 2003 11:25:24 GMT

> > That looks like the traditional 'check-extensions' behaviour. Given
> > that it appends the default extension for the mime-type, in this
> > case, image/jpeg, jpeg is appended to a jpg file. I haven't changed
> > this code at all, so I can only imagine that this has always been
> > its behaviour (or someone changed MimeUtils). Anyway, it doesn't
> > look very hard to fix with a couple of tweaks to MimeUtils (e.g
> > adding a confirmExtension(mimeType, extension) function.

> I saw the same problem at the weekend and I'm on the way to prepare
> the diff. I simply do the reverse check before to see if the
> extensions matches my mimetype. Only if not, I change it using the old
> code.
> The problem with the null is simple. When MimeUtils doesn't find an
> extension, it returns null. This should be read as, keep as is, don't
> change please. For this part, I haven't looked into the code yet, but
> added the missing mime-types. I think this HashMap should be filled
> via cocoon.xconf, but I haven't time to implement it.

Let me know if/when you've done it. Maybe it'll be my first CVS patch!

Regards, Upayavira

View raw message