cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <vadim.gritse...@verizon.net>
Subject Re: cvs commit: cocoon-2.1/src/webapp/samples/xsp/xsp cacheable.xsp
Date Thu, 01 May 2003 13:19:33 GMT
Bertrand,

While you are at it... Are you sure method

public Serializable getKey()


is called? AbstractServerPage implements Cacheable, not 
CacheableProcessingComponent...

Vadim



bdelacretaz@apache.org wrote:

>bdelacretaz    2003/05/01 06:00:23
>
>  Modified:    src/webapp/samples/xsp/xsp cacheable.xsp
>  Log:
>  cache validity time set from request parameter
>  
>  Revision  Changes    Path
>  1.3       +21 -11    cocoon-2.1/src/webapp/samples/xsp/xsp/cacheable.xsp
>  
>  Index: cacheable.xsp
>  ===================================================================
>  RCS file: /home/cvs/cocoon-2.1/src/webapp/samples/xsp/xsp/cacheable.xsp,v
>  retrieving revision 1.2
>  retrieving revision 1.3
>  diff -u -r1.2 -r1.3
>  --- cacheable.xsp	1 May 2003 10:08:20 -0000	1.2
>  +++ cacheable.xsp	1 May 2003 13:00:22 -0000	1.3
>  @@ -14,12 +14,20 @@
>   </xsp:structure>
>   
>   <xsp:logic>
>  -    // how long to keep the contents of this page in cache
>  -    final int VALIDITY_SECS = 15;
>   
>       // artificial slowdown to make the effects of the cache visible
>       final int DELAY_SECS = 2;
>   
>  +    private int getValidityFromRequest() {
>  +        int result = 15;
>  +        try {
>  +            result = Integer.valueOf(request.getParameter("validity")).intValue();
>  +        } catch(Exception e) {
>  +            // keep default value
>  +        }
>  +        return result;
>  +    }
>  +
>       /**
>       * Generate the unique key for the cache.
>       *
>  @@ -50,9 +58,9 @@
>       *         component is currently not cacheable.
>       */
>       public SourceValidity getValidity() {
>  -       // keep in cache for VALIDITY_SECS
>  +       // keep in cache for our validity time
>          return CacheValidityToSourceValidity.createValidity(
>  -           new DeltaTimeCacheValidity(0, VALIDITY_SECS));
>  +           new DeltaTimeCacheValidity(0, getValidityFromRequest()));
>       }
>    </xsp:logic>
>   
>  @@ -82,7 +90,8 @@
>   
>           <para>
>             All other request parameters do not influence cache status, but
>  -            my validity will expire after <xsp:expr>VALIDITY_SECS</xsp:expr>
seconds (see source).
>  +            my validity will expire after <xsp:expr>getValidityFromRequest()</xsp:expr>
seconds
>  +            (set by 'validity' URL parameter when page is generated).
>           </para>
>   
>           <para>
>  @@ -104,12 +113,13 @@
>   
>           <para>Test links:
>               <ul>
>  -                <li><a target="_new" href="cacheable?pageKey=one">test
with pageKey=one</a></li>
>  -                <li><a target="_new" href="cacheable?pageKey=two">test
with pageKey=two</a></li>
>  -                <li><a target="_new" href="cacheable?pageKey=three&amp;other=abc">test
with pageKey=three, other=abc</a></li>
>  -                <li><a target="_new" href="cacheable?pageKey=three&amp;other=xyz">test
with pageKey=three, other=xyz</a></li>
>  +                <li><a target="_new" href="cacheable?pageKey=one">pageKey=one</a></li>
>  +                <li><a target="_new" href="cacheable?pageKey=two">pageKey=two</a></li>
>  +                <li><a target="_new" href="cacheable?pageKey=three&amp;other=abc">pageKey=three,
other=abc</a></li>
>  +                <li><a target="_new" href="cacheable?pageKey=three&amp;other=xyz">pageKey=three,
other=xyz</a></li>
>  +                <li><a target="_new" href="cacheable?pageKey=three&amp;other=wow&amp;validity=5">pageKey=three,
other=wow and 5 seconds of cache validity</a></li>
>               </ul>
>           </para>
>       </content>
>     </page>
>  -</xsp:page>
>  +</xsp:page>
>  \ No newline at end of file
>  
>  
>  
>
>  
>



Mime
View raw message