Return-Path: 
 <cocoon-dev-return-39919-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org
Received: (qmail 88061 invoked by uid 500); 6 Apr 2003 17:46:57 -0000
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:cocoon-dev-help@xml.apache.org>
list-unsubscribe: <mailto:cocoon-dev-unsubscribe@xml.apache.org>
list-post: <mailto:cocoon-dev@xml.apache.org>
Reply-To: cocoon-dev@xml.apache.org
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 88048 invoked from network); 6 Apr 2003 17:46:56 -0000
Received: from unknown (HELO pulse.betaversion.org) (217.158.110.65)
  by daedalus.apache.org with SMTP; 6 Apr 2003 17:46:56 -0000
Received: (qmail 13987 invoked from network); 6 Apr 2003 17:46:54 -0000
Received: from unknown (HELO apache.org) (stefano@80.105.91.155)
  by pulse.betaversion.org with SMTP; 6 Apr 2003 17:46:54 -0000
Message-ID: <3E906837.5000300@apache.org>
Date: Sun, 06 Apr 2003 19:47:35 +0200
From: Stefano Mazzocchi <stefano@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
 rv:1.3b) Gecko/20030401 Minotaur/0.1a
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: cocoon-dev@xml.apache.org
Subject: Re: cvs commit:
 cocoon-2.1/src/scratchpad/src/org/apache/cocoon/transformation
 JXPathTransformer.java
References: <20030406045048.64572.qmail@icarus.apache.org>
 <3E901543.30407@apache.org> <3E906712.8080600@verizon.net>
In-Reply-To: <3E906712.8080600@verizon.net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

on 4/6/03 7:42 PM Christopher Oliver wrote:

> Stefano Mazzocchi wrote:
> 
> 
>>on 4/6/03 6:50 AM coliver@apache.org wrote:
>>
>> 
>>
>>
>>>coliver     2003/04/05 20:50:48
>>>
>>> Modified:    src/scratchpad/src/org/apache/cocoon/transformation
>>>                       JXPathTransformer.java
>>> Log:
>>> Fixed breakage caused by Stefano's cleanup: I think you need to be equally picky about testing before checking in ;)
>>> 
>>> Revision  Changes    Path
>>> 1.4       +0 -1      cocoon-2.1/src/scratchpad/src/org/apache/cocoon/transformation/JXPathTransformer.java
>>> 
>>> Index: JXPathTransformer.java
>>> ===================================================================
>>> RCS file: /home/cvs/cocoon-2.1/src/scratchpad/src/org/apache/cocoon/transformation/JXPathTransformer.java,v
>>> retrieving revision 1.3
>>> retrieving revision 1.4
>>> diff -u -r1.3 -r1.4
>>> --- JXPathTransformer.java	2 Apr 2003 21:38:38 -0000	1.3
>>> +++ JXPathTransformer.java	6 Apr 2003 04:50:48 -0000	1.4
>>> @@ -564,7 +564,6 @@
>>>              String variable = getExpr(a.getValue(JXPATH_VALUEOF_SELECT));
>>>              Iterator iter = 
>>>                  JXPathContext.compile(variable).iteratePointers(getContext());
>>> -            foreachStack.push(variable);
>>>              foreachStack.push(iter);
>>>          }
>>>      }
>>>   
>>>
>>
>>Wait a second.
>>
>>This is my patch taken from
>>
>>http://cvs.apache.org/viewcvs.cgi/cocoon-2.1/src/scratchpad/src/org/apache/cocoon/transformation/JXPathTransformer.java.diff?r1=1.2&r2=1.3
>>
>>@@ -579,7 +574,6 @@
>>        if (ignoreEventsCount == 0) {
>>            DocumentFragment frag = endRecording();
>>            Iterator iter = (Iterator)foreachStack.pop();
>>-            String variable = (String)foreachStack.pop();
>>            while (iter.hasNext()) {
>>                Pointer ptr = (Pointer)iter.next();
>>                pushContext(ptr.getNode());
>>
>>I removed a variable that was popped out of the stack but never used.
>>
> 
> You also removed the "pop" itself, but you didn't remove the 
> corresonding "push".

<banging my head on the wall/>

>>I really don't see how this can be related to the above!
>>
>> 
>>
> 
> Which is exactly why code inspection isn't good enough :)  

I guess I win the cocoon-dumb-ass-of-the-month award.

And this sums up to two given the CVS mess I made last month.

:-(

Sorry about that.


-- 
Stefano.