Return-Path: 
 <cocoon-dev-return-38637-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org
Received: (qmail 41728 invoked by uid 500); 18 Mar 2003 09:35:04 -0000
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:cocoon-dev-help@xml.apache.org>
list-unsubscribe: <mailto:cocoon-dev-unsubscribe@xml.apache.org>
list-post: <mailto:cocoon-dev@xml.apache.org>
Reply-To: cocoon-dev@xml.apache.org
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 41710 invoked from network); 18 Mar 2003 09:35:03 -0000
Received: from unknown (HELO pulse.betaversion.org) (217.158.110.65)
  by daedalus.apache.org with SMTP; 18 Mar 2003 09:35:03 -0000
Received: (qmail 26461 invoked from network); 18 Mar 2003 09:35:15 -0000
Received: from unknown (HELO apache.org) (stefano@80.105.91.155)
  by pulse.betaversion.org with SMTP; 18 Mar 2003 09:35:15 -0000
Message-ID: <3E76E861.6050203@apache.org>
Date: Tue, 18 Mar 2003 10:35:29 +0100
From: Stefano Mazzocchi <stefano@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
 rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: cocoon-dev@xml.apache.org
Subject: Re: exclusion of certain blocks from build is busted
References: <1047698782.1065.26588.camel@ighp>
 	<3E7309EF.2050009@a1.net>	<1047785609.1065.41157.camel@ighp>
 	<3E744906.4010601@apache.org> 	<1047854508.21962.54359.camel@ighp>
 	<1047874962.21962.58142.camel@ighp> <1047882885.1065.59673.camel@ighp>
 	<3E75CF92.5080306@apache.org> <1047955024.21962.72933.camel@ighp>
 <3E76CD14.4050501@apache.org>
In-Reply-To: <3E76CD14.4050501@apache.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Nicola Ken Barozzi wrote:
> 
> David Crossley wrote, On 18/03/2003 3.37:
> 
>> Stefano Mazzocchi wrote:
>>
>>> David Crossley wrote:
>>
>>
>> <snip/>
>>
>>>> Found it - there is extra whitespace at the end of these
>>>> three lines in block.properties, i.e. after the =true
>>>>
>>>> Thank the lord, i am not going mad. Sounds like we
>>>> need normalize-space() whenever properties are read.
>>>> Call in the XSL/build experts.
>>>
>>>
>>> Oh, gosh, ant is *very* picky. Fixed in CVS.
>>
>>
>> Gee, i could have easily committed such a simple fix to
>> remove the extra whitespace. However, i left it because as
>> discussed above, it needs a more robust solution, like using
>> normalize-space() in the blocks-build.xsl, but i could not
>> see where to do this. Quick hacks just leave the way open for
>> the build to be busted again like this and causing someone
>> else three days of grief.
> 
> 
> I had moved the properties in xml files, so that the whitespace there is 
> really easy to see. Why did we resort back to property files for it?

Because flat properties are much less verbose and much more friendly to 
edit.

you have a point on whitespace, though, but I still think this is an ant 
problem, not ours.

Stefano.