Return-Path: Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org Received: (qmail 9571 invoked by uid 500); 18 Mar 2003 07:39:01 -0000 Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: cocoon-dev@xml.apache.org Delivered-To: mailing list cocoon-dev@xml.apache.org Received: (qmail 9452 invoked from network); 18 Mar 2003 07:39:00 -0000 Received: from fep01.tuttopmi.it (HELO fep01-svc.flexmail.it) (212.131.248.100) by daedalus.apache.org with SMTP; 18 Mar 2003 07:39:00 -0000 Received: from apache.org ([80.204.154.181]) by fep01-svc.flexmail.it (InterMail vM.5.01.05.09 201-253-122-126-109-20020611) with ESMTP id <20030318073912.KFNH11971.fep01-svc.flexmail.it@apache.org> for ; Tue, 18 Mar 2003 08:39:12 +0100 Message-ID: <3E76CD14.4050501@apache.org> Date: Tue, 18 Mar 2003 08:39:00 +0100 From: Nicola Ken Barozzi Reply-To: nicolaken@apache.org Organization: Apache Software Foundation User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312 X-Accept-Language: en-us, en MIME-Version: 1.0 To: cocoon-dev@xml.apache.org Subject: Re: exclusion of certain blocks from build is busted References: <1047698782.1065.26588.camel@ighp> <3E7309EF.2050009@a1.net> <1047785609.1065.41157.camel@ighp> <3E744906.4010601@apache.org> <1047854508.21962.54359.camel@ighp> <1047874962.21962.58142.camel@ighp> <1047882885.1065.59673.camel@ighp> <3E75CF92.5080306@apache.org> <1047955024.21962.72933.camel@ighp> In-Reply-To: <1047955024.21962.72933.camel@ighp> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N David Crossley wrote, On 18/03/2003 3.37: > Stefano Mazzocchi wrote: > >>David Crossley wrote: > > > >>>Found it - there is extra whitespace at the end of these >>>three lines in block.properties, i.e. after the =true >>> >>>Thank the lord, i am not going mad. Sounds like we >>>need normalize-space() whenever properties are read. >>>Call in the XSL/build experts. >> >>Oh, gosh, ant is *very* picky. Fixed in CVS. > > Gee, i could have easily committed such a simple fix to > remove the extra whitespace. However, i left it because as > discussed above, it needs a more robust solution, like using > normalize-space() in the blocks-build.xsl, but i could not > see where to do this. Quick hacks just leave the way open for > the build to be busted again like this and causing someone > else three days of grief. I had moved the properties in xml files, so that the whitespace there is really easy to see. Why did we resort back to property files for it? -- Nicola Ken Barozzi nicolaken@apache.org - verba volant, scripta manent - (discussions get forgotten, just code remains) ---------------------------------------------------------------------