cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@s-und-n.de>
Subject RE: setupPipeline() in AbstractCachingProcessingPipeline
Date Thu, 20 Mar 2003 10:57:48 GMT
Hi Stephan,

you don't have to ask for changes (if they make sense). I don't
own the code :)

So, making the code more understandable is good.

> From: Stephan Michels [mailto:stephan@apache.org]
>
> can I move the part where you generate the validity objects
> into a separate method, like generateValidities() ?
> I whould like to enhance the profiler components to measure
> the setup() time.
>
> Thanks.
>
> BTW, can you add a check for null in AbstractAggregatedValidity.add().
> I got sometimes NPEs in AggregatedValidity.isValid(), and don't know which
> Component add a Null validity.
>
I personally would rather search for the problem (or component) that
tries to add a null validity. By adding a check, the stacktrace should
show where the problem lies.
If you add the extra check, we have to fix the problem and have to
remove the check before release anyway.

Regards
Carsten


Mime
View raw message